Fix localized DirectML adapter errors in Python - #32543
Open
Aziz Muminov (AzizMuminov) wants to merge 1 commit into
Open
Aziz Muminov (AzizMuminov) wants to merge 1 commit into
Aziz Muminov (AzizMuminov) wants to merge 1 commit into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot started reviewing on behalf of
Aziz Muminov (AzizMuminov)
September 10, 2026 15:33
View session
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix addresses the reported failure and includes appropriate regression coverage.
Pull request overview
Adds a stable ASCII error for invalid DirectML adapter IDs crossing into Python.
Changes:
- Replaces localized DXGI adapter-enumeration exceptions with an ASCII message.
- Adds a Windows DirectML regression test.
File summaries
| File | Description |
|---|---|
onnxruntime/core/providers/dml/dml_provider_factory.cc |
Produces a locale-independent adapter error. |
onnxruntime/test/python/onnxruntime_test_python.py |
Verifies Python receives the readable error. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
/azp run Linux Android Emulator QNN CI Pipeline |
|
Commenter does not have sufficient privileges for PR 32543 in repo microsoft/onnxruntime |
Author
|
adrastogi Hisham Chowdhury (@hisham-hchowdhu) Could you please review this focused DirectML error-handling fix when you have a moment? It adds regression coverage for the localized Windows Python error path. The automated review found no issues; CI is awaiting maintainer authorization. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #32082
Testing
python3 -m py_compile onnxruntime/test/python/onnxruntime_test_python.pygit diff --check