Reject zero divisors in CUDA Mod kernels - #32546
Draft
Tianlei Wu (tianleiwu) with Copilot wants to merge 5 commits into
Draft
Tianlei Wu (tianleiwu) with Copilot wants to merge 5 commits into
Tianlei Wu (tianleiwu) with Copilot wants to merge 5 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Co-authored-by: tianleiwu <30328909+tianleiwu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix CUDA Mod kernel to include zero divisor check
Reject zero divisors in CUDA Mod kernels
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
ModandFmod."Integer modulo by zero"consistently with the CPU provider.% 0.int64divisor containing zero.Motivation and Context
CUDA integer
Modpreviously evaluated%without validating the divisor, causing undefined behavior when it contained zero. CPU already rejects the same input cleanly; this change aligns CUDA behavior.