Add contributor sorting option to compile_contributors.py - #32549
Open
Tianlei Wu (tianleiwu) wants to merge 2 commits into
Open
Add contributor sorting option to compile_contributors.py#32549Tianlei Wu (tianleiwu) wants to merge 2 commits into
Tianlei Wu (tianleiwu) wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The implementation matches the stated behavior and includes focused coverage.
Pull request overview
Adds configurable contributor-summary ordering while preserving contribution-count sorting by default.
Changes:
- Adds
--sort-bywith contribution and alphabetical modes. - Adds deterministic tie-breaking and focused unit tests.
File summaries
| File | Description |
|---|---|
tools/python/compile_contributors.py |
Implements and documents configurable sorting. |
tools/python/test_compile_contributors.py |
Tests both sorting modes. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
--sort-byto order the contributor summary by contribution count or contributor name.Motivation and Context
Release-note contributor acknowledgments should be alphabetized, while existing workflows can continue sorting by contribution count.
Testing
.venv\Scripts\python.exe tools\python\test_compile_contributors.py.venv\Scripts\python.exe -m ruff check --config pyproject.toml tools/python/compile_contributors.py tools/python/test_compile_contributors.py.venv\Scripts\python.exe -m ruff format --check --config pyproject.toml tools/python/compile_contributors.py tools/python/test_compile_contributors.py