feat(arty): introduce runtime facade and core crates - #727
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
✅ Version increments look sufficient
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #727 +/- ##
=======================================
Coverage 100.0% 100.0%
=======================================
Files 583 583
Lines 62930 62930
=======================================
Hits 62930 62930 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
Mark arty_core as an intentional private dependency until it exposes foundational runtime contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: fefa2c62-c45c-4ede-822b-6d07ab109081
There was a problem hiding this comment.
🟡 Changes recommended
The new public-surface test uses size_of without bringing it into scope, and should be adjusted to avoid relying on implicit availability.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Introduces the initial arty runtime facade crate and an intentionally empty arty_core foundation crate, establishing a small, feature-gated public surface that primarily re-exports existing workspace primitives.
Changes:
- Added
artyandarty_corecrates at0.2.0, including crate docs and packaging/metadata setup. - Implemented
artyas a facade re-exportingthread_aware_coreunderarty::coreand selectedticktypes behindtime/test-utilfeatures. - Added public-surface tests to validate the feature-gated facade.
File summaries
| File | Description |
|---|---|
| crates/arty/tests/public_surface.rs | Adds compile-time surface checks for feature-gated re-exports. |
| crates/arty/src/lib.rs | Defines the arty facade modules and feature-gated re-exports. |
| crates/arty/README.md | Adds generated crate README describing features and policies. |
| crates/arty/docs/STABILIZATION.md | Documents stabilization policy for re-exported dependencies. |
| crates/arty/docs/PANICS.md | Documents panic/unwind safety policy expectations. |
| crates/arty/docs/IO.md | Documents I/O ownership/injection policy. |
| crates/arty/docs/DESIGN.md | Documents high-level design intent. |
| crates/arty/Cargo.toml | Adds crate metadata, features, deps, and external-types allowlist. |
| crates/arty_core/src/lib.rs | Introduces empty foundation crate with crate-level docs. |
| crates/arty_core/README.md | Adds generated README for the foundation crate. |
| crates/arty_core/Cargo.toml | Adds crate metadata and coverage-gate configuration for empty crate. |
| Cargo.toml | Registers arty and arty_core in the workspace dependency set. |
| Cargo.lock | Records new workspace packages in the lockfile. |
Review details
- Files reviewed: 12/13 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| //! Verifies the feature-gated public facade. | ||
|
|
||
| #[test] |
Introduces the initial
artyruntime facade and intentionally emptyarty_corefoundation at version 0.2.0.artyre-exports thread-awareness types througharty::coreand exposes selected Tick primitives through independenttimeandtest-utilfeatures. It also adds minimal design, I/O, panic-safety, and stabilization policies plus feature-surface tests.