fix(tracing): send addStackToTracingNoReply on the LocalUtils connection - #1967
Open
monkey (Develop-KIM) wants to merge 2 commits into
Open
fix(tracing): send addStackToTracingNoReply on the LocalUtils connection#1967monkey (Develop-KIM) wants to merge 2 commits into
monkey (Develop-KIM) wants to merge 2 commits into
Conversation
Yury Semikhatsky (yury-s)
approved these changes
Sep 4, 2026
Yury Semikhatsky (yury-s)
left a comment
Yury Semikhatsky (yury-s)
left a comment
Member
There was a problem hiding this comment.
Do you mind adding a test?
The existing coverage lives in TestBrowserTypeConnect#shouldRecordTraceWithSources, which is skipped unless PLAYWRIGHT_JAVA_SRC is set, and the job that sets it runs only *TestTracing*. The new class passes the source root through Playwright.CreateOptions instead, so it runs in the regular test job.
Contributor
Author
|
Added a test: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Connection.internalSendMessageaddressedaddStackToTracingNoReplytolocalUtils.guidbut sent it over its own transport. For a browser fromconnect()that transport is the server pipe, not the driver connection that ownsLocalUtils, so the stack session opened bytracingStartednever received anything andsetSources(true)produced no sources.localUtils.connectioninstead, matchingthis._localUtils?.addStackToTracingNoReply(...)inpackages/playwright-core/src/client/connection.ts. For a local connection that is the same object, so nothing changes there.TestBrowserTypeConnect#shouldRecordTraceWithSourcesalready covered this and fails onmain(0 sources instead of 1); it passes with the change. It never ran on CI because the sources job filters on-D test=*TestTracing*.Fixes #1962