fix: reject MQTT WebSocket text frames - #140
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #138
Summary
Reject inbound WebSocket text data frames instead of forwarding their UTF-8 bytes to the MQTT decoder.
MQTT 5 requires MQTT control packets to use WebSocket binary data frames. The adapter now returns a clear
InvalidDatatransport error for any text frame, which takes the normal connection teardown path. Binary frames and Ping, Pong, and Close handling are unchanged.Tests
Added deterministic localhost-only WebSocket tests that verify:
The main regression failed before the production change because the text frame decoded as
Ok(RawPacket { first_byte: 48, ... }).Validation after the fix:
cargo test --lib --features websockets io::tokio_ws::tests(3 passed)make test(default, integration, and WebSocket feature sets passed)cargo fmt --all -- --checkgit diff --checkNo external broker or network service is required by the new tests.