fix: enforce authentication method continuity - #142
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #136
Problem
Enhanced authentication accepted incoming
AUTHpackets and successfulCONNACKpackets without proving that their Authentication Method matched the method selected by the client. Reauthentication also reused the peer-provided method instead of retaining the method that initiated the exchange.Fix
Require every incoming enhanced-auth packet to carry the exact expected Authentication Method. Reauthentication now stores the initiating method alongside its completion notifier and uses that retained value throughout the exchange. Missing or mismatched methods fail as protocol errors rather than completing authentication.
Tests
Deterministic in-memory transport tests cover:
AUTHCONNACKValidation completed with isolated build artifacts:
cargo fmt --all -- --check: passedgit diff --check: passed