fix: validate CONNACK session state - #143
Open
OllieinCanada wants to merge 1 commit into
Open
Conversation
Signed-off-by: Oliver Slapinski <olliefromcanada@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #137
Problem
The client accepted
Session Present = 1even after a Clean Start request or when it had no corresponding local session state. That can leave client and broker with contradictory views of packet identifiers, subscriptions, and in-flight messages.Fix
Track whether the client has resumable local session state and validate successful CONNACK packets against both that state and the preceding Clean Start value. Contradictory responses now fail as protocol errors, while a legitimate reconnect with retained local state remains accepted. Existing session-expiration paths clear the new state marker.
Tests
Deterministic in-memory transport tests cover:
Session Present = 1is rejectedSession Present = 1is rejectedValidation completed with isolated build artifacts:
cargo fmt --all -- --check: passedgit diff --check: passed