ci: add cargo publishing - #100
Merged
Merged
Conversation
Signed-off-by: cpendery <cpendery@vt.edu>
cpendery (cpendery)
marked this pull request as ready for review
August 6, 2026 22:12
cpendery (cpendery)
assigned
Ayman Bagabas (aymanbagabas) and unassigned
Ayman Bagabas (aymanbagabas)
There was a problem hiding this comment.
Why do we need this? Can't we just cargo publish ... things with the right token permissions?
Member
Author
There was a problem hiding this comment.
removed a lot of the script to just include publishing in the pipeline
Comment on lines
+43
to
+44
| - name: Verify shell-use crate package | ||
| run: node .github/scripts/release/publish-crate.mjs --dry-run |
Member
Author
There was a problem hiding this comment.
I think it's useful to do dry runs for all the packaging before we start publishing
Comment on lines
+368
to
+391
| publish-crates: | ||
| needs: | ||
| - verify | ||
| - release | ||
| if: always() && needs.verify.result == 'success' && (needs.release.result == 'success' || github.event_name == 'workflow_dispatch') | ||
| runs-on: ubuntu-latest | ||
| environment: | ||
| name: crates-io | ||
| url: https://crates.io/crates/shell-use | ||
| permissions: | ||
| contents: read | ||
| id-token: write | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| with: | ||
| ref: ${{ env.RELEASE_TAG }} | ||
|
|
||
| - run: | | ||
| rustup toolchain install stable --profile default | ||
| rustup default stable | ||
|
|
||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: "24" |
Member
Author
There was a problem hiding this comment.
the auth stage is required because I setup trusted publishing for the pipeline, https://crates.io/docs/trusted-publishing
Signed-off-by: cpendery <cpendery@vt.edu>
Ayman Bagabas (aymanbagabas)
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.