Skip to content

[Bug Fix] on-prem TFS missing collections - #453

Open
Shawn McGough (ShawnMcGough) wants to merge 2 commits into
microsoft:masterfrom
ShawnMcGough:master
Open

[Bug Fix] on-prem TFS missing collections#453
Shawn McGough (ShawnMcGough) wants to merge 2 commits into
microsoft:masterfrom
ShawnMcGough:master

Conversation

@ShawnMcGough

Copy link
Copy Markdown

The TfsConnection constructor allows for invalid serviceUrl when using on-prem server. Subsequent commands will report success, even though they fail to do anything.

Testing setup:
On-prem server with a serviceUrl in the following format: http://www.example.com/tfs
PAT token created at the server level ex: http://www.example.com/tfs/_usersSettings/tokens

tfx login
Service URL: {http://www.example.com/tfs}

it should fail here, because there is no collection path, but it does not

enter PAT token and run a command. for example, this one will incorrectly report success.
tfx build tasks upload --task-zip-path {path to task}

With this PR, login will correctly fail if no collection path is provided when using on-prem.a

@ShawnMcGough
Shawn McGough (ShawnMcGough) requested a review from a team as a code owner March 6, 2025 12:04
@ShawnMcGough

Copy link
Copy Markdown
Author

Kirill Ivlev (@kirill-ivlev) thanks for approving! Do you know who else can approve to get this PR completed? My customer still runs into this issue occasionally and it would be great to have this in the official release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants