Skip to content

Add Android ARM64 release target - #4734

Open
jakebailey wants to merge 5 commits into
mainfrom
jabaile/android
Open

Add Android ARM64 release target#4734
jakebailey wants to merge 5 commits into
mainfrom
jabaile/android

Conversation

@jakebailey

Copy link
Copy Markdown
Member

Fixes #4715
Closes #4729

Copilot AI review requested due to automatic review settings July 24, 2026 20:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds an Android ARM64 package target for native TypeScript releases.

Changes:

  • Builds and publishes Android ARM64 binaries.
  • Prevents unsafe fanotify probing on Android.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Herebyfile.mjs Enables the Android ARM64 release package.
internal/fswatch/fanotify_linux.go Disables fanotify detection on Android.

Comment thread internal/fswatch/fanotify_linux.go
@robertkirkman

Copy link
Copy Markdown

Is there a way I can download the GitHub Actions CI artifact from this PR?

@jakebailey

Copy link
Copy Markdown
Member Author

No, but I could temporarily enable that (it'd be too big overall to have on always)

@robertkirkman

Copy link
Copy Markdown

If it's not too much trouble I would like to test it, but if it would take too long then don't worry about it.

@jakebailey

Copy link
Copy Markdown
Member Author

Temporarily made this upload artifacts; will undo when you've checked.

@robertkirkman

robertkirkman commented Jul 31, 2026

Copy link
Copy Markdown

Thanks;

When I downloaded the artifact, there doesn't appear to be an Android binary in it, unless I'm confused and I'm missing it, or it's just slightly hidden:

image image

do you know where it went?

extra information about .vsix files

Also, regarding the .vsix files, on Android we have at least 2 distinct native ports of variants of VScode, code-server and code-oss, and it is technically possible to compile custom .vsix files (either containing, or modified to detect, native binaries) in such a way that they become compatible with both of them. I have developed one here,

https://github.com/termux/termux-packages/blob/7c7deb18daf09f7845c640c86c6dea0f33e2b110/x11-packages/codelldb/build.sh

(All .vsix files that do not contain native binaries, which is most, work as-is in our builds of VSCode for Android without rebuilding)

however, I'm not sure exactly whether it would be worth the effort for you to support the VSCode package for Android as well as the NPM package; There are at least a few people using the .vsix file I built and distribute to pkg install code-oss-extension-codelldb, so these builds of VSCode do have users and few of them do use the native .vsix file I built, but I expect the NPM package to have a lot more users in comparison.

@jakebailey

Copy link
Copy Markdown
Member Author

We're only going to publish VSIXes that vsce lets us work with, so I doubt we'd do more than what we already have.

I forgot that CI only builds the core platforms, so I'll hack android in there quick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Request for support for Android

3 participants