-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add Infer function return type refactoring code action
#4749
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
xeho91
wants to merge
19
commits into
microsoft:main
Choose a base branch
from
xeho91:xeho91/lsp-refactor-infer-return-type
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
cf06ca3
Add refactoring code action `Infer function return type`
xeho91 37ef7ab
Add support `fourslash` for refactor code actions
xeho91 ef5db47
Add integration tests for infering return type code action refactor
xeho91 be8c7b8
Strenghten testing strategy with post-refactor comparison
xeho91 776d88d
Fix paren-less arrow handling case
xeho91 7db11ee
Swap `codeActionKindContains` arguments
xeho91 71a15fe
Fix handling type predicates
xeho91 8263c3c
Stop ancestor walk at blocks and arrow function boundaries
xeho91 4c11c49
Defer checker acquisition until after cheap applicability checks
xeho91 31f98ba
Pass `AllowUnresolvedNames` to type-node builder - fixes computed pro…
xeho91 c14941b
Filter refactor providers by per-action Kinds against `Context.Only`
xeho91 ba248b0
Use `GetTouchingPropertyName` to exclude leading trivia from token lo…
xeho91 cc7f34a
Use stable sort for equal-position edits in `fourslash` verifier
xeho91 2c5437c
Remove initializer shortcuts from `findConvertibleAncestor`
xeho91 1587095
Add coverage for `Context.Only` filtering on refactor providers
xeho91 e959063
Add `TypePredicateToTypePredicateNodeEx` with configurable internal f…
xeho91 41e2c6a
Treat empty kind in `Context.Only` as matching all refactor actions
xeho91 7eebf25
Return disabled code actions with not-applicable reasons
xeho91 c2810de
Gate disabled refactor on `DisabledSupport` client capability
xeho91 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.