Optimize export lookup and simple activation - #772
Draft
Andrew Arnott (AArnott) wants to merge 3 commits into
Draft
Optimize export lookup and simple activation#772Andrew Arnott (AArnott) wants to merge 3 commits into
Andrew Arnott (AArnott) wants to merge 3 commits into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Document the activation performance investigation and retain only the non-expression optimizations on the active PR branch. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OnImportsSatisfiedcallbacksImportManyactivationPERFORMANCE.mdThis branch does not add expression-compiled constructors, setters, or activation plans. That experiment is preserved separately on
perf/compiled-activation-plansand has no pull request.Performance
Three-run median from the IocPerformance scenarios (single-threaded, 500,000 iterations):
Compared with the original VS MEF measurements, this is approximately 30x faster for shared retrieval, 7x faster for simple non-shared activation, and 1.4-2.6x faster for the imported graph scenarios. The much larger imported-graph gains and their additional JIT cost are isolated on the topic branch.
Validation
Microsoft.VisualStudio.Composition.Tests: 2,064 net8.0 and 2,107 net472 tests passedValidation pipeline
vs-mef validation build 15110883