Fix extension README image roots - #591
Merged
Brandon Waterloo [MSFT] (bwateratmsft) merged 3 commits intoAug 21, 2026
Merged
Conversation
Configure VSCE to resolve relative README images from each extension's directory after the monorepo resource relocation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a93f1e75-d2ea-4ead-989d-437c363085b7
Brandon Waterloo [MSFT] (bwateratmsft)
requested a review
from a team
as a code owner
August 21, 2026 13:18
Copilot started reviewing on behalf of
Brandon Waterloo [MSFT] (bwateratmsft)
August 21, 2026 13:19
View session
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the packaging scripts for the Container Tools and Docker extensions so VSCE can rewrite README image URLs to an absolute base URL after the resource directory relocation, ensuring images render correctly in packaged artifacts/Marketplace.
Changes:
- Add
--baseImagesUrlto thevsce packagescripts for both extensions. - Point the base image URL at the corresponding extension folder in the
microsoft/vscode-containersrepository.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| extensions/vscode-containers/package.json | Adds a --baseImagesUrl to ensure README images under resources/readme/ can be rewritten to absolute URLs during packaging. |
| extensions/vscode-docker/package.json | Adds a --baseImagesUrl to align packaging behavior across extensions (even though the current README has no images). |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Add trailing slashes to both extension image base URLs so their directory semantics are explicit. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a93f1e75-d2ea-4ead-989d-437c363085b7
VSCE joins base image URLs and relative paths correctly without trailing slashes, as confirmed from the packaged README. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: a93f1e75-d2ea-4ead-989d-437c363085b7
Brandon Waterloo [MSFT] (bwateratmsft)
enabled auto-merge (squash)
August 21, 2026 13:46
Patrick Verbrugge (patverb)
approved these changes
Aug 21, 2026
Brandon Waterloo [MSFT] (bwateratmsft)
deleted the
agents/fix-broken-image-links-readme
branch
August 21, 2026 13:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖
Summary
Validation
git diff --check