Let the server determine cwd on its own

[Peter Wagenet (wagenet)]

If cwd is not specified in the ServerOptions then the Language Server will use its own logic to determine the correct working directory, including the root of the workspace. This then allows eslint.runtime to be set to "node" which will be run in the root of the workspace. For projects using tools like Volta, this leads to it using the Volta-specified node version as expected.

[Dirk Bäumer (dbaeumer)]

This is for security reasons not so easy. I need to think about the consequences of this and if trusted workspace allow this now. Using the extension host's CWD ensures that no unwanted binary code is loaded.

[Dirk Bäumer (dbaeumer)]

What we can always do is to have a opt-in setting for this which we should consider anyways since the change might be a surprise for others.

[Peter Wagenet (wagenet)]

Dirk Bäumer (@dbaeumer) opt-in is ok for me. My goal is very much for the process to run in the context of my workspace.

[Peter Wagenet (wagenet)]

Dirk Bäumer (@dbaeumer) do you have any guidance on how to implement this? I'd still love to see this happen but my understanding of the codebase is pretty limited.

[Dirk Bäumer (dbaeumer)]

Here are some pointers:

• you need to introduce a setting here: https://github.com/microsoft/vscode-eslint/blob/dbaeumer/dominant-starfish-moccasin/package.json#L51
• then use it when we create the client to determine the right CWD here: https://github.com/microsoft/vscode-eslint/blob/dbaeumer/dominant-starfish-moccasin/client/src/client.ts#L402 Best is to use the workspace folder. What we need to decide is the following: which folder to use when no workspace folder is open and which folder to use if more than one workspace folder is open

[Tobias Hernstig (thernstig)]

Peter Wagenet (@wagenet) this does not solve #1727. Can you unlink it?

[Kamolon osh (shah20033)]

index.html

[Dirk Bäumer (dbaeumer)]

Peter Wagenet (@wagenet) are you still working on the PR?

[Peter Wagenet (wagenet)]

Dirk Bäumer (@dbaeumer) apologies for the silence here. I am not actively working on this.