refactor: replace substr with slice & use startsWith and endsWith - #2032
Open
Noritaka Kobayashi (noritaka1166) wants to merge 6 commits into
Open
refactor: replace substr with slice & use startsWith and endsWith#2032Noritaka Kobayashi (noritaka1166) wants to merge 6 commits into
Noritaka Kobayashi (noritaka1166) wants to merge 6 commits into
Conversation
Dirk Bäumer (dbaeumer)
requested changes
Aug 6, 2025
| if (extension !== undefined) { | ||
| const extname = path.extname(filePath); | ||
| if (extname.length === 0 && filePath[0] === '.') { | ||
| if (extname.length === 0 && filePath.startsWith('.')) { |
There was a problem hiding this comment.
Why is this better than the array access?
Contributor
Author
There was a problem hiding this comment.
Dirk Bäumer (@dbaeumer)
SonarQube, which I often use, says this, but do you prefer array access?
There was a problem hiding this comment.
I would like to keep the array access.
Noritaka Kobayashi (noritaka1166)
requested a review
from Dirk Bäumer (dbaeumer)
September 30, 2025 16:31
Dirk Bäumer (dbaeumer)
requested changes
Dec 8, 2025
| if (/^CLI: /.test(result)) { | ||
| result = result.substr(5); | ||
| if (result.startsWith('CLI: ')) { | ||
| result = result.slice(5); |
There was a problem hiding this comment.
One more. Why do you use slice instead of substring. I makes it easier to see that you are manipulating a string.
| end: textDocument.positionAt(diff.originalStart + diff.originalLength) | ||
| }, | ||
| newText: fixedContent.substr(diff.modifiedStart, diff.modifiedLength) | ||
| newText: fixedContent.slice(diff.modifiedStart, diff.modifiedStart + diff.modifiedLength) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I did the following refactoring.