Expose null progress reporter detection - #1827
Open
volksec wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
volksec
marked this pull request as ready for review
July 30, 2026 18:21
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isNullProgressReporterfromvscode-languageserverconstructor.namecheck with the public helperMotivation
Consumers currently need to rely on implementation details to determine whether a request supplied a real work-done reporter. For example, Pyright compared the reporter constructor with a reporter created by
attachWorkDone. A public type guard makes this check explicit and keepsNullProgressReporteritself private.This avoids adding a required property to
WorkDoneProgressReporter, which would break external implementations of that interface.Fixes #847.
Validation
npm --prefix server run allgit diff --check