Replace deprecated source-map-resolve with a maintained alias - #2900
Open
Alexandro Marques (alexandroit) wants to merge 1 commit into
Open
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Author
|
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sourceMapsCombinatorcurrently importssource-map-resolve@0.5.3and calls its synchronousresolveSyncAPI while combining debugger source maps, including Windows drive-letter handling.This changes only the existing dependency key and lockfile to the exact npm alias:
Imports, the existing drive-letter workaround, and the repository's ambient declaration remain unchanged. The replacement preserves the seven-function CommonJS API, synchronous and callback behavior, and error metadata; it supports the repository's Node 20 CI runtime and corrects Windows cross-drive path retention.
Disclosure: I maintain
@stackline/source-map-resolve. It is an MIT compatibility fork and is not affiliated with or endorsed by the original maintainer. This is a maintenance proposal, not a claim that a cleansource-map-resolve@0.5.3installation is currently vulnerable.Validation on the current base commit
5403c435aeb41fa4c3542490f37adab71782e5d4:npm cinpx gulpnpm run build— 0 errors; the same 157 existing warningssourceMapsCombinatorMocha test — 1 passingnpm test -- --verbose— 358 passing, 1 pendingnpm run test-localization -- --verbose— 2 passing when run after the required gulp/build sequenceThe package separately characterizes shared ordinary behavior against 0.5.3, but does not reproduce that release's deprecated dependency topology or claim byte-for-byte 0.5.x equivalence. I retained the local type declaration to keep this migration focused; adopting the package's stricter first-party types can be evaluated separately.