Skip to content

fix: honor omitted primaries-required input - #3

Open
dale-lakes wants to merge 1 commit into
mikehardy:mainfrom
dale-lakes:agent/optional-primaries-required
Open

fix: honor omitted primaries-required input#3
dale-lakes wants to merge 1 commit into
mikehardy:mainfrom
dale-lakes:agent/optional-primaries-required

Conversation

@dale-lakes

Copy link
Copy Markdown

Summary

  • Treat an omitted primaries-required input as disabled.
  • Keep online busy primary runners eligible when that option is omitted, allowing jobs to queue for them.
  • Add regression coverage and rebuild the checked-in action bundle.

Root cause

@actions/core.getInput() returns an empty string for an omitted optional input. The availability check only distinguished undefined, so the empty string entered the primaries-required branch and skipped every busy runner.

Any non-empty primaries-required value retains the existing free-runner count behavior.

Validation

  • npm exec --yes --package=npm@10 -- npm run all
  • ESLint passed.
  • Action bundle rebuilt with ncc.
  • Jest: 6 tests passed.

@dale-lakes
dale-lakes marked this pull request as ready for review August 19, 2026 04:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant