Skip to content

Replace 100vw with 100% where classic scrollbars cause overflow #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
minimaldesign wants to merge 1 commit into from
Closed

Replace 100vw with 100% where classic scrollbars cause overflow #71

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion dist/css/component.header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,7 +129,7 @@ xxl: 1920px
position: fixed;
top: 0;
left: 0; /* deliberately physical: full-viewport overlay pinned to the screen edge */
width: 100vw;
width: 100%; /* of the viewport, scrollbar excluded; 100vw is not */
height: 100svh;
overflow-y: auto;
padding: var(--lg3);
Expand Down
4 changes: 3 additions & 1 deletion dist/css/component.readProgressBar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,9 @@ xxl: 1920px
width: 0;
}
to {
width: 100vw;
/* Not 100vw: with a classic scrollbar the bar would hit full visible
width before the scroll reaches the bottom */
width: 100%;
}
}

Expand Down
4 changes: 3 additions & 1 deletion dist/css/global.layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,9 @@ xxl: 1920px
.layout {
display: flex;
flex-direction: column;
width: 100vw;
/* Not 100vw: vw ignores classic scrollbars (Windows/Linux), which makes
any scrollable page overflow horizontally by the scrollbar's width */
width: 100%;
min-height: 100vh;

.layout_content {
Expand Down
6 changes: 4 additions & 2 deletions dist/mcss.components.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,7 @@ li + li::before {
position: fixed;
top: 0;
left: 0; /* deliberately physical: full-viewport overlay pinned to the screen edge */
width: 100vw;
width: 100%; /* of the viewport, scrollbar excluded; 100vw is not */
height: 100svh;
overflow-y: auto;
padding: var(--lg3);
Expand Down Expand Up @@ -1550,7 +1550,9 @@ li + li::before {
width: 0;
}
to {
width: 100vw;
/* Not 100vw: with a classic scrollbar the bar would hit full visible
width before the scroll reaches the bottom */
width: 100%;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion dist/mcss.components.min.css
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 3 additions & 1 deletion dist/mcss.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1597,7 +1597,9 @@ details {
.layout {
display: flex;
flex-direction: column;
width: 100vw;
/* Not 100vw: vw ignores classic scrollbars (Windows/Linux), which makes
any scrollable page overflow horizontally by the scrollbar's width */
width: 100%;
min-height: 100vh;

.layout_content {
Expand Down
2 changes: 1 addition & 1 deletion dist/mcss.min.css
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/styles/framework/component.header.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@
position: fixed;
top: 0;
left: 0; /* deliberately physical: full-viewport overlay pinned to the screen edge */
width: 100vw;
width: 100%; /* of the viewport, scrollbar excluded; 100vw is not */
height: 100svh;
overflow-y: auto;
padding: var(--lg3);
Expand Down
4 changes: 3 additions & 1 deletion src/styles/framework/component.readProgressBar.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,8 @@
width: 0;
}
to {
width: 100vw;
/* Not 100vw: with a classic scrollbar the bar would hit full visible
width before the scroll reaches the bottom */
width: 100%;
}
}
4 changes: 3 additions & 1 deletion src/styles/framework/global.layout.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,9 @@
.layout {
display: flex;
flex-direction: column;
width: 100vw;
/* Not 100vw: vw ignores classic scrollbars (Windows/Linux), which makes
any scrollable page overflow horizontally by the scrollbar's width */
width: 100%;
min-height: 100vh;

.layout_content {
Expand Down
Loading