Treat zombied descendants as terminated in dev-lane isolation tests - #11
Merged
Conversation
Process-group termination can leave dead descendants in zombie state until container PID 1 reaps them. Make the isolation assertions distinguish those non-runnable processes from surviving workers instead of relying on kill(pid, 0) alone. Source: original Co-Authored-By: OpenAI Codex <codex@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
os.kill(pid, 0)returns success for zombied processes, causing flaky failures in CI/container environments where PID 1 reaping can be delayed.Description
/proc/<pid>/statto detectZ(zombie) state and treat such PIDs as terminated inpid_is_aliveinops/devlane/dispatch/tests/launch_support.py._alivehelper inops/devlane/task/tests/test_run.pyused by the orphan/termination tests.kill(pid, 0)and Permission/Lookup handling) when procfs is unavailable or unreadable.Testing
python3 -m pytest -q ops/devlane/dispatch/testsand the suite passed (247 passed).python3 -m pytest -q ops/devlane/task/testsand the suite passed (151 passed, 26 subtests passed).fixtures,harness,hooks,telemetry, andworkflowall passed (see individual counts in the run).python3 -m compileall -q ops/devlanewhich succeeded, and ran the repo lint checkops/devlane/workflow/checks/lint.pywhich correctly refused due to the repository lacking a rootruff.toml(this is a pre-existing configuration omission, not a regression from this change).Codex Task