fix(ble): show MeshCore devices when platformName is empty - #2
Open
DataArchitectPro wants to merge 1 commit into
Open
fix(ble): show MeshCore devices when platformName is empty#2DataArchitectPro wants to merge 1 commit into
DataArchitectPro wants to merge 1 commit into
Conversation
On Android BLE scan, platformName is often empty; the device name is in advName. Include bonded devices via systemDevices (Nordic UART), cache display names for UI, and extend scan timeout to 10 seconds. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
advNamebut notplatformNameFlutterBluePlus.systemDevices(Nordic UART Service UUID)getBluetoothDisplayName()cache so the picker shows names likeMeshCore-…instead of a blank titleProblem
scanBluetoothDevices()filtered scan results using onlyr.device.platformName. On Android, BLE scan often leavesplatformNameempty while the local name is available inr.advertisementData.advName. Bonded devices were also not considered.Symptom: MeshCore nodes (e.g. Heltec T114) paired in system Bluetooth settings do not appear in Wardrive's "Scan Bluetooth" list, while other apps (e.g. MeshMapper) see them fine.
Related: mintylinux/Meshcore-Wardrive-Android#16 (similar
platformName-only filter on WhisperOS).Changes
lib/services/lora_companion_service.dart— scan/filter logic, bonded device lookup, display name helperlib/screens/map_screen.dart— usegetBluetoothDisplayName()in the device pickerTest plan
MeshCore-…