Require dune 3.17 for the wasm_of_ocaml stanza - #321
Merged
Conversation
samoht
force-pushed
the
dune-3.17
branch
3 times, most recently
from
July 10, 2026 05:46
1206d5c to
9501ce4
Compare
The wasm_of_ocaml (wasm_files ...) stanza needs dune language 3.17, so bump dune-project and the dune lower bound in every package -- otherwise opam may resolve an older dune (e.g. 2.3) that cannot parse the project. Lang 3.17 also makes the dev profile treat warning 32 (unused value) as an error, so drop the unused pp_cstruct in the fuzzer and use the compile-test binding in the lwt ppx test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
wasm_of_ocaml (wasm_files ...)stanza needs dune 3.17. Split out of #320 so it can land independently; #320 is rebased on top.