Release v0.4.0 with admission-time eviction holds - #1
Merged
Conversation
A PodDisruptionBudget is pre-checked: every disrupter that dry-runs budgets refuses to start while one blocks, which pins the node. The same not-yet answer given at admission time is invisible until the moment of the attempt, which is the one moment delay is expected and retried by every drainer in existence. Behind an understudy.sh/experimental-eviction-hold annotation on the CR: no budget is created, and the observe-only eviction webhook gains a hold: evictions of protected pods are answered with the same 429 a budget would return until a stand-in is ready, the phase says Relaxed, or hostage mode is off. Protection detection moves from owned-budget lookup to resolving the Understudy that covers the pod, which both modes need. The held attempt itself is the doom signal, so signal and hold are one mechanism and the state machine is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Compatibility
understudy_pdb_relaxed_totalbecomesunderstudy_hold_relaxed_totalunderstudy_node_pinned_totalis removedsignals.evictionWebhook*,signals.pinDetection, andfailsafevalues are retired; webhook settings move towebhook.**-eviction-observerbecomes*-eviction-holdValidation