Add a single "copy config and data" operation to FlexConfigBuffer - #490
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Resizing the combined buffer no longer invalidates its cached bind group.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Combines color configuration and bytecode uploads into one GPU buffer write.
Changes:
- Adds
FlexConfigBuffer::write. - Updates pixel and voxel color rendering to use the combined upload.
- Removes separate config and tape copy methods.
File summaries
| File | Description |
|---|---|
fidget-wgpu/src/buf.rs |
Implements combined config/data writes. |
fidget-wgpu/src/color.rs |
Exposes combined color-buffer upload. |
fidget-wgpu/src/pixel/effects/mod.rs |
Uses combined upload for pixel coloring. |
fidget-wgpu/src/voxel/effects/mod.rs |
Uses combined upload for voxel coloring. |
Review details
- Files reviewed: 4/4 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mkeeter
force-pushed
the
combined-config-flex-copy
branch
from
September 11, 2026 19:01
cd97be8 to
8505899
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This may be slightly more efficient!