fix: Handle Empty SSE Terminator in LM Studio/llama.cpp - #113
Open
deathwish wants to merge 3 commits into
Open
Conversation
Owner
|
Thank you for your contribution. If everything looks and works fine this will be merged. Interesting though since I never ran into this. |
Author
|
Awesome, thanks much! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Sporadically, reading from LM Studio or llama.cpp's OpenAI endpoint would hang with "streaming" status indicated despite inference having completed, likely due to MTP tearing. Google informed me that this was an expected behavior and the fix was recognizing an empty payload as an alternative terminator. I've been running this fix for several million tokens worth of generation and it's been rock solid, no hangs or early termination whatsoever.
Contributor License Agreement (CLA)
To accept your code, we legally need you to agree to our CLA so we can maintain the project's Business Source License (BSL) and future open-source transitions.
xbetween the brackets like this:[x])