Feat: Add roi_align_rotated - #36
Open
DerrickUnleashed wants to merge 20 commits into
Open
Conversation
DerrickUnleashed
marked this pull request as ready for review
August 2, 2026 21:13
cregouby
reviewed
Aug 17, 2026
Collaborator
|
@DerrickUnleashed , |
Keep both roi_align_rotated (feature branch) and box_iou_rotated (main) across all generated export/build/registration files.
Author
Yes I have completed resolving them |
The TORCH_LIBRARY_FRAGMENT schema registration was not being picked up
at runtime across shared libraries on macOS, causing
findSchemaOrThrow("torchvision::roi_align_rotated") to fail.
Bypass the PyTorch dispatcher by calling the CPU kernels and autograd
function directly instead of routing through findSchemaOrThrow.
cregouby
requested changes
Aug 18, 2026
cregouby
left a comment
Collaborator
There was a problem hiding this comment.
praise Nice addition, clear and straightforward, thanks
todo indexing and documentation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ops_roi_align_rotated()/nn_roi_align_rotated(), a CPU RoI align pooling op for rotated boxes, ported from mmcv (Apache-2.0). Includes dispatcher + autograd kernels, R API + docs, and tests.Closes #32