Skip to content

Check return of AppendCertsFromPEM #515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmb merged 1 commit into from
Aug 19, 2026
Merged

Check return of AppendCertsFromPEM #515

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion internal/tmpbbs/pullpeer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@ import (
"context"
"crypto/tls"
"crypto/x509"
"errors"
"fmt"
"log/slog"
"os"
"strings"
Expand All @@ -31,6 +33,10 @@ type pullPeer struct {

const minClientTimeout = 15 * time.Second

// ErrTrustedCAParsing is caused by failure to parse any trusted CA
// certificates from a PEM file.
var ErrTrustedCAParsing = errors.New("error parsing trusted CA certificates")

func newPullPeer(address string, caCertPool *x509.CertPool, interval time.Duration,
postStore *PostStore,
) (*pullPeer, error) {
Expand Down Expand Up @@ -164,7 +170,9 @@ func RunPullPeers(addresses []string, trustedCAPath string, interval time.Durati
}

caCertPool = x509.NewCertPool()
caCertPool.AppendCertsFromPEM(pemCerts)
if !caCertPool.AppendCertsFromPEM(pemCerts) {
return fmt.Errorf("%w: %s", ErrTrustedCAParsing, trustedCAPath)
}
}

var waitBetween time.Duration
Expand Down