Jm/face - #4
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f44d99b94c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "YOLOv10s_face", | ||
| "YOLOv6m_face", | ||
| "YOLOv6n_face", | ||
| "YOLOv8l_face", |
There was a problem hiding this comment.
Preserve compatibility exports for the removed YOLOv6 models
Existing code importing YOLOv6m_face or YOLOv6n_face from either mblt_vision.face_detection or the lazy top-level namespace now fails at import time because these entries are removed from __all__. Even if their YAML artifacts must be withdrawn, retain deprecated compatibility classes—the existing create_model_class missing-YAML path can provide an actionable construction error—rather than silently deleting public names.
AGENTS.md reference: AGENTS.md:L41-L43
Useful? React with 👍 / 👎.
| - 960 | ||
| - 960 |
There was a problem hiding this comment.
Synchronize the new face-model input defaults with maintained guides
Changing the YOLOv8m/YOLOv8l preprocessing default from 640 to 960 is a durable model-behavior change affecting normal inference and compilation, but this commit updates none of the required agent guide, canonical skill, Claude guidance, or relevant README. Update those maintained surfaces in the same change so package documentation and future compatibility work do not continue assuming the old geometry.
AGENTS.md reference: AGENTS.md:L160-L163
Useful? React with 👍 / 👎.
No description provided.