Add opt-in correction for zero-duration survey activities - #402
Merged
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #402 +/- ##
==========================================
+ Coverage 82.86% 82.97% +0.10%
==========================================
Files 231 232 +1
Lines 15835 15978 +143
==========================================
+ Hits 13121 13257 +136
- Misses 2714 2721 +7 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Rounded survey clocks can produce zero-duration activities when one trip arrives at the same reported time the next trip departs. These zeros distort downstream activity-duration distributions.
Changes
correct_zero_durationssurvey parameter.ValueErrorfor ENTD until its parser loads and standardizes the trip times already present in the survey.Example (if relevant)
The feature is disabled by default and does not require an external CSV.
AI-assisted contribution
If substantial, briefly describe:
Checklist