refactor: extract stripLeadingDashes helper + cover CLI arg-parsing edge cases#6136
Draft
mark-wiemer wants to merge 2 commits into
Draft
refactor: extract stripLeadingDashes helper + cover CLI arg-parsing edge cases#6136mark-wiemer wants to merge 2 commits into
mark-wiemer wants to merge 2 commits into
Conversation
Adds unit tests for scenarios in the new parseArgs-based CLI option loading that were previously unexercised: - parse-args: bare numeric positional -> UNSUPPORTED error; string and empty-string args input; falsy config objects skipped while merging; positionals merged across multiple config objects; non-boolean value kept for a boolean option in equals form. - options: non-Mocha parse errors are printed and exit with code 1. Test-only change; no production code is modified. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Replace seven copies of `flag.replace(/^--?/, "")` across parse-args.js, run-option-metadata.cjs, and node-flags.cjs with a single exported `stripLeadingDashes` helper in run-option-metadata.cjs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
mark-wiemer
changed the title
mark-wiemer
marked this pull request as draft
July 4, 2026 22:34
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
status: accepting prsOverview
Stacked on top of #6124. Two related follow-ups to that PR:
stripLeadingDasheshelper dedupesflag.replace(/^--?/, "")in seven places