Add initialize(InitializeRequest) overload to MCP client#1055
Draft
nquinquenel wants to merge 1 commit into
Draft
Add initialize(InitializeRequest) overload to MCP client#1055nquinquenel wants to merge 1 commit into
nquinquenel wants to merge 1 commit into
Conversation
aad0166 to
b62d67b
Compare
117d168 to
3d063e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
initialize(InitializeRequest)overloads toMcpAsyncClientandMcpSyncClient, consistent withcallTool(CallToolRequest)LifecycleInitializer, with client-side protocol version validation and defensive copying of_metaMcpTransportSessionNotFoundException); clear stored request on client closedocs/client.mdDesign notes
This follows the approach agreed in #940 (not the closed builder-level
initializeRequestMeta()approach from #1046).Call
initialize(InitializeRequest)before any other client method if custom metadata is required; lazy initialization triggered by methods likelistTools()orcallTool()uses the default request built from client builder settings.Test plan
./mvnw -pl mcp-core -Dtest=LifecycleInitializerTests,McpAsyncClientTest,McpSyncClientTest test./mvnw -pl mcp-core verify_metacopy, unsupported protocol version rejection, init reuse, re-init with stored custom request, default request on re-init when none stored, and clear on close / closeGracefullyMockMcpClientTransportFixes #940