Skip to content

fix(agent_hub): scrub url credentials, headers and stdio args on outb… - #956

Merged
mushenL merged 2 commits into
modelscope:mainfrom
mushenL:fix-leak
Sep 2, 2026
Merged

fix(agent_hub): scrub url credentials, headers and stdio args on outb…#956
mushenL merged 2 commits into
modelscope:mainfrom
mushenL:fix-leak

Conversation

@mushenL

@mushenL mushenL commented Sep 1, 2026

Copy link
Copy Markdown
Collaborator

…ound sync

Change Summary

fix(agent_hub): scrub url credentials, headers and stdio args on outbound sync

The outbound scrubbers only matched secret-named keys and blanked env
blocks, so credentials survived the upload when carried in URL query
strings / userinfo, arbitrary-named HTTP headers, or stdio command-line
flags. Add carrier-level rules to the shared scrubbers and wire in every
framework that collects structured configs (ms-agent, hermes, qwenpaw,
openhuman); clean configs still round-trip byte-identical.

Checklist

  • The pull request title is a good summary of the changes - it will be used in the changelog
  • Unit tests for the changes exist
  • Run pre-commit install and pre-commit run --all-files before git commit, and passed lint check.
  • Documentation reflects the changes where applicable

@mushenL
mushenL merged commit 3b44489 into modelscope:main Sep 2, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants