Fix nullable errors. Bump php-di to 7. Remove spatie data transfer - #142
Merged
Conversation
dpellenwood
approved these changes
Jul 27, 2026
dpellenwood
left a comment
dpellenwood
left a comment
Collaborator
There was a problem hiding this comment.
A couple requests and questions, but this looks great overall!
| - php-versions: '8.1' | ||
| wordpress-version: '5.3.12' | ||
| php-versions: [ '8.1', '8.2', '8.3' ] | ||
| wordpress-version: [ 'latest', '6.4.5', '6.7.2' ] |
Collaborator
There was a problem hiding this comment.
Curious why check WP 6.4?
Collaborator
Author
There was a problem hiding this comment.
That was check for back compatibility. I don't expect anyone running this version, but wanted to check anyway. Bumped it to 6.6.5 and latest patch 6.9.5
dpellenwood
approved these changes
Jul 28, 2026
dpellenwood
left a comment
dpellenwood
left a comment
Collaborator
There was a problem hiding this comment.
Looks great, @MlKilderkin ! Let's get this merged and new packages built. Thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Tribe\Libs\Field_Models\DTO), keeping 4.x BC (castValue/castTypeand optionalSpatie\DataTransferObject\*aliases).string|Stringable, and migrate WP_Downloader commands to#[AsCommand].5.x; document upgrade path and usage examples.Upgrade notes (4.x → 5.x)
moderntribe/tribe-libs(or publishedsquare1-*packages) to^5.0.Field_Modelusage; Spatie typehints still work via aliases when Spatie is not installed.square1-*:^5.0, consume the monorepo (moderntribe/tribe-libs) or a VCS/path install.