Copy the selected clip with Command-C - #82
Open
alvst wants to merge 1 commit into
Open
Conversation
- Add a Copied to Clipboard toast, shown after every successful copy (Command-C and the context menu's Copy action both go through copyItem). - Promote the copied clip to the front of history, since copying an existing clip back to the pasteboard is a deliberate re-use of it and the clipboard monitor correctly ignores Pesty's own pasteboard writes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
⌘C in the bar copies the selected clip to the pasteboard, the same path the context menu's Copy already uses. Every successful copy now shows a brief "Copied to Clipboard" toast, so a copy that doesn't paste anywhere still gives feedback.
What changed
copyItem.Screenshots
Before:

After:

Notes for review
alvie/pr-16-paste-reliabilityadds a byte-identicalClipboardStore.promoteCopiedItem(_:at:). Git places them in different regions of the file, so it will not conflict — it will produce two identical methods and a redeclaration error. Whichever of the two merges second, delete the duplicate.This feature should be bundled into v2.
Part of #80.