Add a "Play sound on copy" setting - #90
Open
alvst wants to merge 2 commits into
Open
Conversation
Plays the system "Tink" sound when a clip is copied from the bar via copyItem(_:) - kept audibly distinct from the existing "Play sound on paste" toggle, which plays "Pop" from PasteService.paste(_:). Defaults to on, matching Alvie's Pesty.
Both sound toggles now ship disabled - an update shouldn't introduce a new audible behavior existing users never asked for, and the two sibling settings shipping with opposite defaults read as an oversight.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pesty can already play a sound on paste. This adds the sibling toggle for copy, using an audibly distinct system sound so the two events aren't confusable.
What changed
copyItem(_:).PasteService.paste(_:).Screenshots
Before:
After:
Notes for review
This feature should be bundled into v2.
Part of #80.