Skip to content

fix(security): move @modelcontextprotocol/sdk past GHSA-6qxp-vccf-f47h - #1286

Merged
aviggiano merged 1 commit into
unstablefrom
fix/mcp-sdk-advisory
Oct 6, 2026
Merged

aviggiano merged 1 commit into
unstablefrom
fix/mcp-sdk-advisory

Conversation

@aviggiano

@aviggiano aviggiano commented Oct 6, 2026 •

Copy link
Copy Markdown
Collaborator

Problem

CI on unstable (e35eeea) fails the production dependency advisory gate on a High advisory published on 2026-10-06:

dependency advisory policy: unapproved high production advisory GHSA-6qxp-vccf-f47h in @modelcontextprotocol/sdk

The SDK's OAuth client could send credentials to an authorization server that the MCP server chooses. The vulnerable range is >= 1.12.0, < 1.31.0, and the workspace lock pins 1.29.0 through @smthrs/agents (^1.29.0).

Change

Tests

  • pnpm install --frozen-lockfile from a clean node_modules: passes.
  • pnpm -w security:dependency-advisories: passes (only the existing http-cache-semantics exception remains).
  • pnpm -w build, pnpm -w typecheck: pass.
  • bun test --timeout 30000 scripts/ci/*.test.ts: 79/79.

🤖 Generated with Claude Code

RetriggerConfidence Score: 5/5

The PR appears safe to merge; no actionable regression was identified.

Summary

The PR moves the workspace’s @modelcontextprotocol/sdk resolution from 1.29.0 to 1.31.0 and updates its dependent peer-resolution references.

  • Adds a changelog entry describing the advisory addressed and distinguishing the workspace install from the workflow engine’s npm install.
Diagram
%%{init: {'theme': 'neutral'}}%%
flowchart LR
  Lock[Workspace pnpm lockfile] --> SDK[SDK 1.31.0]
  Lock --> Smithers[Workspace Smithers peer instances]
  Run[Run workflow installation] --> Npm[npm resolution at fixed cutoff]
Loading

Reviews (1) · Last reviewed commit: "fix(security): move @modelcontextprotoco..."

- Lockfile only: @modelcontextprotocol/sdk 1.29.0 -> 1.31.0 (in range of @smthrs/agents' ^1.29.0); no override.

- The engine install from npm already resolves 1.31.0 at the 2026-10-01 cutoff.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@aviggiano
aviggiano requested a review from a team as a code owner October 6, 2026 17:47
@aviggiano
aviggiano merged commit 5b463c8 into unstable Oct 6, 2026
17 checks passed
@aviggiano
aviggiano deleted the fix/mcp-sdk-advisory branch October 6, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant