Repository navigation
fix(security): move @modelcontextprotocol/sdk past GHSA-6qxp-vccf-f47h - #1286
Merged
Merged
Conversation
- Lockfile only: @modelcontextprotocol/sdk 1.29.0 -> 1.31.0 (in range of @smthrs/agents' ^1.29.0); no override. - The engine install from npm already resolves 1.31.0 at the 2026-10-01 cutoff. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
CI on
unstable(e35eeea) fails the production dependency advisory gate on a High advisory published on 2026-10-06:The SDK's OAuth client could send credentials to an authorization server that the MCP server chooses. The vulnerable range is
>= 1.12.0, < 1.31.0, and the workspace lock pins 1.29.0 through@smthrs/agents(^1.29.0).Change
pnpm-lock.yaml:@modelcontextprotocol/sdk1.29.0 → 1.31.0. The parent's range already allows it, so there is no override. No new packages; the rest of the diff is peer-hash renames.runinstalls from npm already resolves at its 2026-10-01 dependency cutoff (fix(security): move proxy-addr, vue, source-map-js and prosemirror-view past the October advisories #1283), so the workspace and the shipped engine now match.Tests
pnpm install --frozen-lockfilefrom a cleannode_modules: passes.pnpm -w security:dependency-advisories: passes (only the existinghttp-cache-semanticsexception remains).pnpm -w build,pnpm -w typecheck: pass.bun test --timeout 30000 scripts/ci/*.test.ts: 79/79.🤖 Generated with Claude Code
The PR appears safe to merge; no actionable regression was identified.
Summary
The PR moves the workspace’s
@modelcontextprotocol/sdkresolution from 1.29.0 to 1.31.0 and updates its dependent peer-resolution references.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Lock[Workspace pnpm lockfile] --> SDK[SDK 1.31.0] Lock --> Smithers[Workspace Smithers peer instances] Run[Run workflow installation] --> Npm[npm resolution at fixed cutoff]Reviews (1) · Last reviewed commit: "fix(security): move @modelcontextprotoco..."