Read codespace telemetry URL from org secret - #54
Merged
Conversation
The tracking Cloud Function URL was hardcoded and publicly guessable/exposed in this file. The URL now comes from the CODESPACE_TELEMETRY_URL org Codespaces secret; the script no-ops if it's not set.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the hardcoded, publicly-exposed Cloud Function URL in
.devcontainer/track.shwith a read from theCODESPACE_TELEMETRY_URLorg Codespaces secret. The old guessable-name function has been deleted and redeployed under a random name; the new URL is only stored as a secret, never committed. The script no-ops (exits 0) if the secret isn't available, consistent with its existing best-effort behavior.