fix: keep chart tooltips within visible bounds - #486
Open
RomuloGatto wants to merge 3 commits into
Open
Conversation
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Axis tooltips with many series can be taller than the viewport. With
appendToBody: trueand no confinement, ECharts positions the tooltip above the hovered point, leaving the beginning of the tooltip outside the visible area.Keeping the tooltip in the chart, constraining its border box, and enabling internal scrolling keeps every series accessible without covering page chrome.
Validation
Test-suite note
The complete unit binary currently has 49 pre-existing parser/template failures on upstream
master. This change reduces the tooltip regression from two failures to zero; the focused tooltip tests pass and no tooltip failure remains in the full run.Closes #487