fix: drop --accept-routes from tailscale args (v4 passes it by default) - #324
Merged
Merged
Conversation
tailscale/github-action v4 hardcodes --accept-routes in tailscale up (src/main.ts), so repeating it in args fails every attempt with "invalid boolean flag accept-routes: flag provided multiple times". continue-on-error masked this and Sonar steps were silently skipped. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
joscdk
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Validation of #311 (tailscale/github-action v3.3.0 → v4.1.3) via a fresh consumer run (service-audit-log run 30360531261) showed every
tailscale upattempt failing:v4 hardcodes
--accept-routesin theupcommand (src/main.ts L771) — an undocumented breaking change — so ourargs: "... --accept-routes"duplicates the flag.continue-on-error: sonar-non-blockingmasks the failure, so affected runs go green while silently skipping the SonarQube scan (or fail hard where sonar-non-blocking is off).Fix
Remove
--accept-routesfromargsin both workflows; v4 applies it unconditionally, so effective behavior is unchanged.--login-server(Headscale) is still passed throughargsas before.Validation
After merge, re-validate the same way: retrigger a consumer PR (e.g. close/reopen a Renovate PR in service-audit-log) and confirm the Tailscale step joins on attempt 1 and the "Upload results to SonarQube" step runs instead of skipping.
🤖 Generated with Claude Code