fix(windows): do not error on @process.spawn when there is no stdio - #565
Merged
Conversation
Coverage Report for CI Build 1049Coverage remained the same at 77.099%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
Betterlol
reviewed
Aug 21, 2026
Guest0x0
force-pushed
the
fix-windows-no-stdio-spawn
branch
from
August 21, 2026 06:47
2664857 to
483821b
Compare
Guest0x0
added
the
wasm-runtime-port-required
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By default, child process spawned by
@process.spawnetc. inherit stdio channels of current process. On Windows, some programs such as GUI applications simply do not have stdio channel. Previously,@process.spawnwill fail in this case, which is not desirable. This PR fixes the problem by tolerating stdio not present error when inheriting stdio channels in process spawning.