Fix BigInt JSON parse errors - #3467
Conversation
Coverage Report for CI Build 3926Coverage increased (+0.003%) to 94.892%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
|
Superseded by #3679 ( parse_bigint(s.view()) catch {
_ => raise JsonDecodeError(
(path, "BigInt::from_json: invalid number in string representation"))
}That handles every malformed payload in a single pass, rather than pre-validating Verified on current The regression tests are already covered too: Closing — nothing left to land. |
Summary
BigIntJSON decimal strings before calling the aborting parserJsonDecodeErrorfor malformed string payloads instead of abortingTests
moon fmt bigintmoon info bigintmoon test bigintmoon test jsonmoon checkmoon test