[codex] implement WASI poll_oneoff fd polling for moonrun - #1690
Open
peter-jerry-ye wants to merge 1 commit into
Open
[codex] implement WASI poll_oneoff fd polling for moonrun#1690peter-jerry-ye wants to merge 1 commit into
peter-jerry-ye wants to merge 1 commit into
Conversation
Changed Files
|
peter-jerry-ye
marked this pull request as ready for review
May 19, 2026 07:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implement focused WASI
poll_oneoffsupport inmoonrunfor fd read/write readiness.poll_oneoffin the WASI imports.NOTSUPto keep this implementation scoped.rustixfor Unix stdin polling and byte availability.windows-sysfor console and pipe HANDLE semantics that Rustix does not cover.WouldBlockthrough WASIAGAIN.Validation
cargo test --locked -p moonrun --test test test_moonrun_wasi_poll_oneoff -- --nocapturecargo test -p moonruncargo clippy -p moonrun --all-targetscargo fmt --checkcargo check -p moonrun --target x86_64-pc-windows-msvcgit diff --check