Skip to content

fix(syntax): preserve visitor base dispatch #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
myfreess merged 2 commits into from
Aug 20, 2026
Merged

fix(syntax): preserve visitor base dispatch #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0721fba
fix(syntax): preserve visitor base dispatch
myfreess Aug 19, 2026
319be76
fix warnings
myfreess Aug 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion attribute/attribute.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ pub impl Show for Id with fn output(self, logger) {

///|
pub impl Debug for Id with fn to_repr(self) {
@debug.Repr::literal(self.to_string())
@debug.Repr::literal(Show::to_string(self))
}

///|
Expand Down
20 changes: 10 additions & 10 deletions moon_config/legacy_json_wbtest.mbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ test "legacy JSON converts Ast values" {
("object", legacy_obj([("nested", legacy_bool(false, loc))], loc)),
],
loc,
).to_json(),
),
content={
"null": null,
"bool": true,
Expand Down Expand Up @@ -119,7 +119,7 @@ test "legacy JSON folds repeated top-level entries only" {
],
loc,
)
json_inspect(ast.to_json(), content={
json_inspect(ast, content={
"rule": [
{ "name": "rule1", "command": "exe", "env": { "k": "second" } },
{ "name": "rule2", "command": "exe" },
Expand All @@ -131,7 +131,7 @@ test "legacy JSON folds repeated top-level entries only" {
test "legacy JSON preserves numeric repr" {
let loc = legacy_loc()
json_inspect(
legacy_obj([("big", legacy_float("1N", loc))], loc).to_json(),
legacy_obj([("big", legacy_float("1N", loc))], loc),
content=Json::object(
Map::from_array([("big", Json::number(0.0, repr="1N"))]),
),
Expand All @@ -151,7 +151,7 @@ test "legacy JSON postprocesses moon.pkg output" {
#|dev_build(rule: "rule1", input: "a", output: "b")
#|dev_build(rule: "rule2", input: "c", output: "d")
#|
json_inspect(legacy_parse_pkg(source).to_json(), content={
json_inspect(legacy_parse_pkg(source), content={
"warn-list": "+w1",
"supported-targets": "+wasm",
"is-main": true,
Expand Down Expand Up @@ -190,7 +190,7 @@ test "legacy JSON handles package imports aliases and targets" {
#| },
#|)
#|
json_inspect(legacy_parse_pkg(source).to_json(), content={
json_inspect(legacy_parse_pkg(source), content={
"import": [
{
"path": "moonbit-community/fullstack-one-project-doc/shared",
Expand Down Expand Up @@ -221,7 +221,7 @@ test "legacy JSON handles link options" {
#| },
#|)
#|
json_inspect(legacy_parse_pkg(source).to_json(), content={
json_inspect(legacy_parse_pkg(source), content={
"link": {
"wasm-gc": {
"use-js-builtin-string": true,
Expand All @@ -248,7 +248,7 @@ test "legacy JSON postprocesses moon.mod output" {
#|rule(name: "rule1", command: "exe")
#|rule(name: "rule2", command: "exe")
#|
json_inspect(legacy_parse_mod(source).to_json(), content={
json_inspect(legacy_parse_mod(source), content={
"name": "user/mod",
"version": "0.1.0",
"deps": { "dep/a": "1.2.3", "dep/b": "" },
Expand Down Expand Up @@ -287,7 +287,7 @@ test "legacy JSON handles moon.mod metadata options" {
#| source: "src",
#|)
#|
json_inspect(legacy_parse_mod(source).to_json(), content={
json_inspect(legacy_parse_mod(source), content={
"name": "example/dsl_only",
"version": "0.1.0",
"deps": { "moonbitlang/x": "0.4.6", "../dep": "" },
Expand All @@ -313,7 +313,7 @@ test "legacy JSON parses moon.work output" {
#|members = ["./app", "./shared"]
#|preferred_target = "wasm-gc"
#|
json_inspect(legacy_parse_work(source).to_json(), content={
json_inspect(legacy_parse_work(source), content={
"members": ["./app", "./shared"],
"preferred_target": "wasm-gc",
})
Expand All @@ -325,7 +325,7 @@ test "legacy JSON folds duplicate moon.mod keys" {
#|name = "user/first"
#|name = "user/second"
#|
json_inspect(legacy_parse_mod(source).to_json(), content={
json_inspect(legacy_parse_mod(source), content={
"name": ["user/first", "user/second"],
})
}
Loading
Loading