Add CORS headers to static file responses - #2287
Open
srushtigm25 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1953
This adds CORS headers to static file responses when the request origin is allowed by the HTTP configuration.
The change:
passes allowed_origins to static file handlers
validates the request origin using the existing check_origin() logic
adds Access-Control-Allow-Origin for allowed origins
adds test coverage for CORS headers on static file responses
Tests:
pytest tests/_exts/http/ (103 passed)
ruff check .
ty check src/mopidy/_exts/http/handlers.py
git diff --check