-
-
Notifications
You must be signed in to change notification settings - Fork 241
feat: fail-fast retries: jittered backoff bounded by time, not error type #2647
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
dabad8b
feat: retry only transient failures, with exponential backoff and jitter
kixcord 78592e9
fix(native): honor the CONNECT status; keep waiting for a late catalog
kixcord eedf1a6
fix: address review; stop stalling on a backoff that isn't ours
kixcord d863172
refactor: drop retryable/non-retryable error classification
kixcord 66ca2ea
fix: four holes the removal opened up
kixcord 88a356d
refactor(kio): move Backoff out of moq-net's public surface
kixcord 18e0cd7
fix: sort the new kio deps; don't end an import on a quiet pass
kixcord 36cdd1d
fix(hls): drop a redundant closure
kixcord 5480f6f
docs: don't link a private item from a public doc
kixcord 498992c
refactor: inline the backoff instead of sharing a type
kixcord d36a915
fix(native): fold a failover's statuses; correct the gst docs
kixcord 580b1cb
refactor: bound retries by time, not by error type
kixelated 7e1ead1
refactor: restore the HTTP-status shortcut on the short budgets
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When
WebTransport.readyor the HTTP fingerprint fetch never settles, the configured 10-second timeout never fires because#deadlineis initialized here only afterconnect()has already returned an error. The existing pending-WebTransport scenario can therefore leaveReload.closedpending and the status atconnectingindefinitely. Arm the deadline before dialing and abort or race each connection attempt against the remaining budget. (Written by GPT-5.6 Sol)AGENTS.md reference: AGENTS.md:L100-L102
Useful? React with 👍 / 👎.