chore(js/net): defer version bump - #2691
Conversation
Restore @moq/net to 0.3.0 in the package manifest and workspace lockfile. The breaking ReloadProps change remains on dev, while its release version will be selected later. Co-Authored-By: GPT-5 <noreply@openai.com>
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5b12537878
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "name": "@moq/net", | ||
| "type": "module", | ||
| "version": "0.4.0", | ||
| "version": "0.3.0", |
There was a problem hiding this comment.
Keep the manifest version monotonic
When this reaches main, .github/workflows/release-js.yml serializes it behind the parent commit's release (cancel-in-progress: false), which publishes 0.4.0. The subsequent release then runs npmHasVersion(), compares the registry's latest 0.4.0 with this 0.3.0, incorrectly treats 0.3.0 as unpublished, and attempts to republish an immutable version that already exists, failing the JS release job and blocking later packages in the command. Keep a version newer than the published release rather than rolling the manifest backward. (Written by GPT-5.6 Sol)
Useful? React with 👍 / 👎.
Summary
@moq/netfrom 0.4.0 to 0.3.0 in the package manifest and workspace lockfile.ReloadPropsAPI correction from refactor(js/net)!: drop transport from ReloadProps #2665 unchanged.Public API changes
None. This only reverts premature release metadata.
Release safety
release-js.ymlruns only on pushes tomain, notdev.mainand npm currently have@moq/net0.2.3.devbetween refactor(js/net)!: drop transport from ReloadProps #2665 and this correction, so it cannot publish before this change.devis eventually promoted, the final tree moves monotonically from published 0.2.3 to 0.3.0.Test plan
bun install --frozen-lockfilebun run --cwd js/net checkjust js fixgit diff --checkCheckpassed in 3m34s.(Written by GPT-5)