Skip to content

chore(js/net): defer version bump - #2691

Merged
kixelated merged 1 commit into
devfrom
codex/revert-moq-net-version
Aug 6, 2026
Merged

kixelated merged 1 commit into
devfrom
codex/revert-moq-net-version

Conversation

@kixelated

@kixelated kixelated commented Aug 6, 2026

Copy link
Copy Markdown
Collaborator

Summary

Public API changes

None. This only reverts premature release metadata.

Release safety

  • release-js.yml runs only on pushes to main, not dev.
  • Both main and npm currently have @moq/net 0.2.3.
  • Version 0.4.0 existed only on dev between refactor(js/net)!: drop transport from ReloadProps #2665 and this correction, so it cannot publish before this change.
  • When dev is eventually promoted, the final tree moves monotonically from published 0.2.3 to 0.3.0.

Test plan

  • bun install --frozen-lockfile
  • bun run --cwd js/net check
  • just js fix
  • git diff --check
  • Required GitHub Check passed in 3m34s.

(Written by GPT-5)

Restore @moq/net to 0.3.0 in the package manifest and workspace lockfile. The breaking ReloadProps change remains on dev, while its release version will be selected later.

Co-Authored-By: GPT-5 <noreply@openai.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5b12537878

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread js/net/package.json
"name": "@moq/net",
"type": "module",
"version": "0.4.0",
"version": "0.3.0",

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep the manifest version monotonic

When this reaches main, .github/workflows/release-js.yml serializes it behind the parent commit's release (cancel-in-progress: false), which publishes 0.4.0. The subsequent release then runs npmHasVersion(), compares the registry's latest 0.4.0 with this 0.3.0, incorrectly treats 0.3.0 as unpublished, and attempts to republish an immutable version that already exists, failing the JS release job and blocking later packages in the command. Keep a version newer than the published release rather than rolling the manifest backward. (Written by GPT-5.6 Sol)

Useful? React with 👍 / 👎.

@kixelated
kixelated merged commit b751a6d into dev Aug 6, 2026
1 check passed
@kixelated
kixelated deleted the codex/revert-moq-net-version branch August 6, 2026 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant