-
-
Notifications
You must be signed in to change notification settings - Fork 241
feat(js/net)!: route publish and consume through Origins, share one connection per relay #2705
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
b7b6a9e
feat(js/net)!: route publish and consume through Origins, share one c…
kixelated b8800a2
fix(js/net): survive overlapping sessions and hold blind answers steady
kixelated 2e86afb
fix(js/net): follow the table before discovery, and lend origins with…
kixelated 4558b86
feat(js/net)!: make Request the one way to consume by path, and hide …
kixelated 560a75b
fix(js/net): keep shared connections and discovery recoverable
kixelated 0f2a810
feat(js/signals): add Derived, a mapped view with no lifecycle
kixelated 74208a3
fix(js/net): brand the origin getters and seal the Request constructor
kixelated a1d5c5a
fix(js/net): keep the ReloadDelay defaults on an explicitly undefined…
kixelated 17393cf
docs(js): update the origin and component examples
kixelated 26a9ca2
fix(js/net): port dev's new tests onto the origin API
kixelated 9dc03a8
fix(js/signals): relay every source notification from Derived
kixelated 9c462b8
fix(js/net): answer a request whose slot was replaced under it
kixelated 845a764
fix(js/net): release announcement pumps as they close
kixelated 8a57ab5
fix(js/net): gate discovery on every attached session, not any
kixelated 7bcf13f
fix(js/net): give each request its own handle on the route
kixelated dc14a08
build(js): strip @internal symbols from the published declarations
kixelated cbe7d75
fix(js/net): retire a request's route when it retracts, not when it i…
kixelated 9a4e1e6
perf(js/net): wake a request only for its own path
kixelated 6b67531
feat(js/net): tell a request nothing can serve it
kixelated 46c6aa1
docs(js/net): record why a wrong answer to a request is not corrected
kixelated 75ac33e
test(js/net): port the served-subscription helper to the origin API
kixelated 5f4aba1
fix(js/net): stop a request from missing the retraction of a seeded r…
kixelated File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the relay disconnects after a clock subscriber has connected, the discarded session closes but the new origin deliberately outlives it, so neither the broadcast nor its accepted track is closed. The
broadcast.requested()loop remains pending andpublishTrack()continues waking every second even though there is no session or reconnect path; retain the connection and close the origin whenconnection.closedsettles, or useReloadto reconnect.Useful? React with 👍 / 👎.