fix(just): call the shell lint recipe that exists - #2711
Merged
Conversation
#2650 replaced the inline shfmt/shellcheck lines in `ci` with `just _shell-files`, but no such recipe exists, here or anywhere in the history. #2690 and #2707 landed the tracked-scripts change as `_shell <action>`, which is what `_check-common` and `_fix-common` already call; #2650 was carrying the earlier naming and it never got reconciled on the way in. So `just ci` has failed on every PR since that merge, at the shell lint step and after everything expensive: error: justfile does not contain recipe `_shell-files` Point `ci` at `_shell check`, matching `_check-common`. In the CI dev shell shfmt and shellcheck are both present, so the coverage is unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
WalkthroughThe 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
just cicurrently fails on every PR. #2650 replaced the inline shfmt/shellcheck lines in thecirecipe withjust _shell-files, but that recipe does not exist:git log -S"_shell-files:"finds nothing, so it was never defined here or in the history. #2690 and #2707 landed the tracked-scripts change as_shell <action>, which is what_check-commonand_fix-commonalready call. #2650 was carrying the earlier_shell-filesnaming and it never got reconciled on the way in.This points
ciat_shell check, matching_check-common.Why it matters
The step runs after
cargo deny, the full clippy/doc/nextest pass, and the JS build, so every PR burns a complete CI run before failing on it. Six open PRs are affected (#2693, #2697, #2703, #2704, #2705, #2710)._shellno-ops when shfmt or shellcheck is missing, where the old inline lines would have failed. Both are in the CI dev shell, so the coverage in CI is unchanged; locally this now matches whatjust checkalready did.Test plan
nix develop --command just _shell check— resolves and passesnix develop --command just --fmt --check --justfile justfile— cleanPublic API changes
None; repository tooling only.
(Written by Opus 5)
🤖 Generated with Claude Code