Skip to content

fix(just): call the shell lint recipe that exists - #2711

Merged
kixelated merged 1 commit into
mainfrom
claude/fix-just-shell-files
Aug 7, 2026
Merged

fix(just): call the shell lint recipe that exists#2711
kixelated merged 1 commit into
mainfrom
claude/fix-just-shell-files

Conversation

@kixelated

Copy link
Copy Markdown
Collaborator

Summary

just ci currently fails on every PR. #2650 replaced the inline shfmt/shellcheck lines in the ci recipe with just _shell-files, but that recipe does not exist:

error: justfile does not contain recipe `_shell-files`

git log -S"_shell-files:" finds nothing, so it was never defined here or in the history. #2690 and #2707 landed the tracked-scripts change as _shell <action>, which is what _check-common and _fix-common already call. #2650 was carrying the earlier _shell-files naming and it never got reconciled on the way in.

This points ci at _shell check, matching _check-common.

Why it matters

The step runs after cargo deny, the full clippy/doc/nextest pass, and the JS build, so every PR burns a complete CI run before failing on it. Six open PRs are affected (#2693, #2697, #2703, #2704, #2705, #2710).

_shell no-ops when shfmt or shellcheck is missing, where the old inline lines would have failed. Both are in the CI dev shell, so the coverage in CI is unchanged; locally this now matches what just check already did.

Test plan

  • nix develop --command just _shell check — resolves and passes
  • nix develop --command just --fmt --check --justfile justfile — clean

Public API changes

None; repository tooling only.

(Written by Opus 5)

🤖 Generated with Claude Code

#2650 replaced the inline shfmt/shellcheck lines in `ci` with `just
_shell-files`, but no such recipe exists, here or anywhere in the history.
#2690 and #2707 landed the tracked-scripts change as `_shell <action>`, which
is what `_check-common` and `_fix-common` already call; #2650 was carrying the
earlier naming and it never got reconciled on the way in.

So `just ci` has failed on every PR since that merge, at the shell lint step
and after everything expensive:

    error: justfile does not contain recipe `_shell-files`

Point `ci` at `_shell check`, matching `_check-common`. In the CI dev shell
shfmt and shellcheck are both present, so the coverage is unchanged.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 7512857f-5de1-420b-9d5e-b1dc136c2afc

📥 Commits

Reviewing files that changed from the base of the PR and between f4ce4d5 and 60e16ed.

📒 Files selected for processing (1)
  • justfile

Walkthrough

The ci recipe now calls _shell check for shell validation. It no longer invokes shfmt and shellcheck directly over _shell-files.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly states that the existing shell lint recipe is called for just ci.
Description check ✅ Passed The description explains the nonexistent recipe failure and the change to use _shell check.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
✨ Simplify code
  • Create PR with simplified code
  • Commit simplified code in branch claude/fix-just-shell-files

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kixelated
kixelated merged commit 9fc3426 into main Aug 7, 2026
1 check passed
@kixelated
kixelated deleted the claude/fix-just-shell-files branch August 7, 2026 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant