fix(rs): compile moq play in the Windows gate - #2712
Merged
Conversation
`just rs windows` checks default features, and `play` is off by default, so moq-video's wgpu renderer and moq-audio's cpal output had no Windows compile gate at all. Name the feature explicitly. Doing so surfaced a `-D warnings` rustdoc break unique to that build: moq-audio's `playback` module doc links to `crate::capture`, which only exists behind the off-by-default `capture` feature, so `cargo doc` failed on any playback-only build. Drop the link, matching what moq-video's render module already does for its macOS-only variant. Also correct the rendering docs: wgpu picks Vulkan over D3D12 on Windows when the driver offers it, verified against the adapter trace on an RTX 3070 Ti. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Exercise a LOC-framed PCM rendition through decode::Consumer. The test fails when the consumer hardcodes legacy framing because the LOC header leaks into the decoded payload.\n\nCo-Authored-By: GPT-5 <noreply@openai.com>
kixelated
force-pushed
the
claude/windows-compat-pr-2697-2243d1
branch
from
August 7, 2026 03:45
efbff0b to
89ae67f
Compare
kixelated
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on #2697.
Summary
Public API changes
None.
Test plan
Cross-package sync
Documentation is updated alongside the recipe. No wire format, catalog format, public API, or FFI surface changed, so no draft or language-binding updates apply.
(Written by GPT-5)